[SPARK-11899][SQL] API audit for GroupedDataset.#9880
Closed
rxin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-11899][SQL] API audit for GroupedDataset.#9880rxin wants to merge 1 commit intoapache:masterfrom
rxin wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
rxin
commented
Nov 21, 2015
rxin
commented
- Renamed map to mapGroup, flatMap to flatMapGroup.
- Renamed asKey -> keyAs.
- Added more documentation.
- Changed type parameter T to V on GroupedDataset.
- Added since versions for all functions.
1. Renamed map to mapGroup, flatMap to flatMapGroup. 2. Added more documentation. 3. Changed type parameter T to V on GroupedDataset. 4. Added since versions for all functions.
|
Test build #46471 has finished for PR 9880 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
1 similar comment
Contributor
|
Jenkins, retest this please. |
|
Test build #46477 has finished for PR 9880 at commit
|
Contributor
There was a problem hiding this comment.
Should this variable be renamed to vEncoder?
Contributor
Author
There was a problem hiding this comment.
yea that's a good catch. will fix it in my next pr.
Contributor
|
LGTM aside from one minor variable naming nit. |
asfgit
pushed a commit
that referenced
this pull request
Nov 21, 2015
1. Renamed map to mapGroup, flatMap to flatMapGroup. 2. Renamed asKey -> keyAs. 3. Added more documentation. 4. Changed type parameter T to V on GroupedDataset. 5. Added since versions for all functions. Author: Reynold Xin <rxin@databricks.com> Closes #9880 from rxin/SPARK-11899. (cherry picked from commit ff442bb) Signed-off-by: Reynold Xin <rxin@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.